deser array tree from a vortex array#8063
Open
onursatici wants to merge 1 commit into
Open
Conversation
Merging this PR will improve performance by 17.06%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
211.8 µs | 175.7 µs | +20.58% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
225.1 µs | 188.5 µs | +19.39% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
198 µs | 162 µs | +22.24% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
307.9 µs | 272.9 µs | +12.84% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
358 µs | 323.4 µs | +10.71% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing os/array-serialise-columnar (3257531) with os/layout-overrides (e8f8e0d)1
Footnotes
Signed-off-by: Onur Satici <onur@spiraldb.com>
onursatici
force-pushed
the
os/array-serialise-columnar
branch
from
93e517d to
3257531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for serialising a
ArrayNodetree into a vortex array, with array stats. Before we always serialised these into flatbuffers that were appended to the tail of the serialised array buffers. This PR adds the scaffolding to get a vortex array that can later at read time used to deserialise the buffers into ArrayRef's.Main user of this would be the array tree layout, which will land in a followup PR